Introduce support for logging debug entries with Throwable #940
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
injectives
force-pushed
the
feature/logdebugthrowable
branch
2 times, most recently
from
0a95a0d to
7b14fc1
Compare
injectives
force-pushed
the
feature/logdebugthrowable
branch
from
9399c41 to
8d29fa0
Compare
michael-simons
approved these changes
Jun 24, 2021
Contributor
michael-simons
left a comment
michael-simons
left a comment
There was a problem hiding this comment.
Looks good to me. I briefly thought why not adding the new method as default method to the logger interface but then, the default would only be sensible for the dev null logger.
So in the end: Nothing to complain, I'm sorry.
injectives
added a commit
to injectives/neo4j-java-driver
that referenced
this pull request
Jul 6, 2021
injectives
added a commit
to injectives/neo4j-java-driver
that referenced
this pull request
Jul 6, 2021
injectives
added a commit
that referenced
this pull request
Jul 7, 2021
injectives
added a commit
that referenced
this pull request
Jul 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.