Remove Resource.close() method override with misleading javadoc #930
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
injectives
requested review from
gjmwoods and
michael-simons
and removed request for
gjmwoods
michael-simons
requested changes
Jun 16, 2021
Contributor
michael-simons
left a comment
michael-simons
left a comment
There was a problem hiding this comment.
Agree. And please delete lines 24 to 26 (Javadoc comment)
injectives
force-pushed
the
feature/resource
branch
from
94c3dc4 to
d08243d
Compare
Contributor
Author
Good catch, thank you 👍 Updated. |
michael-simons
approved these changes
Jun 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.