Make QueryRunner interface extend AutoCloseable #928
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
injectives
force-pushed
the
feature/qrautoclosable
branch
from
1444c66 to
7cde5e3
Compare
injectives
changed the title
injectives
force-pushed
the
feature/qrautoclosable
branch
from
7cde5e3 to
0773770
Compare
injectives
changed the title
michael-simons
approved these changes
Jun 16, 2021
Contributor
michael-simons
left a comment
michael-simons
left a comment
There was a problem hiding this comment.
I do appreciate that change a lot and for 4.3 this is great.
I wonder if we should - as you already hinted at - rethink this:
Transactions and sessions are both query runners and both resources. The interface inheritance should be a straight line in 5.0
Contributor
Author
|
Thank you 👍 We should consider removing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.