Fix NettyChannelTracker race condition when tracking new channels #905
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o4j#904) This update fixes an issue when `SimpleChannelPool` may invoke the `channelAcquired` method before the `channelCreated` method is called. Since it violates `NettyChannelTracker` contract, it may result in runtime failures. See the following for details: ``` @startuml T1 -> SimpleChannelPool: acquireHealthyFromPoolOrNew activate SimpleChannelPool SimpleChannelPool -> NettyChannelPool: connectChannel activate NettyChannelPool NettyChannelPool -> ChannelFuture: addListener activate ChannelFuture ChannelFuture --> NettyChannelPool: deactivate ChannelFuture NettyChannelPool --> SimpleChannelPool: deactivate NettyChannelPool T2 -> ChannelFuture: setSuccess activate ChannelFuture ChannelFuture -> ChannelFuture: done activate ChannelFuture ChannelFuture --> ChannelFuture: deactivate ChannelFuture SimpleChannelPool -> ChannelFuture: isDone activate ChannelFuture ChannelFuture --> SimpleChannelPool: deactivate ChannelFuture alt isDone case SimpleChannelPool -> NettyChannelTracker: channelAcquired activate NettyChannelTracker NettyChannelTracker --> SimpleChannelPool: deactivate NettyChannelTracker end SimpleChannelPool --> T1: deactivate SimpleChannelPool ChannelFuture -> NettyChannelTracker: channelCreated activate NettyChannelTracker NettyChannelTracker -> ChannelFuture: deactivate NettyChannelTracker ChannelFuture -> T2: deactivate ChannelFuture @enduml ```
injectives
requested review from
bigmontz,
dotStart and
michael-simons
and removed request for
dotStart and
michael-simons
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #904
This update fixes an issue when
SimpleChannelPoolmay invoke thechannelAcquiredmethod before thechannelCreatedmethod is called. Since it violatesNettyChannelTrackercontract, it may result in runtime failures.See the following for details: