Proper handling of cluster failures for transactions #250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Broke out inner classes and provided more tests.
zhenlineo
reviewed
Oct 13, 2016
| @Override | ||
| public void success() | ||
| { | ||
|
|
Contributor
There was a problem hiding this comment.
?? why this and the following ones could be left empty?
Contributor
Author
There was a problem hiding this comment.
sorry, missed a push...
pontusmelke
force-pushed
the
1.1-tx-close
branch
from
cd24162 to
e150ff7
Compare
`RoutingNetworkSession` now delegates instead of extends `NetworkSession`
We weren't checking for the cluster faillures when running on transactions. All operations should check for leader-switches and connection failures and handle them appropriately.
pontusmelke
force-pushed
the
1.1-tx-close
branch
from
e150ff7 to
bb9121c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We weren't checking for the cluster failures when running on transactions.
All operations should check for leader-switches and connection failures and
handle them appropriately.