Fixed expect strust but get xx bug #249
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nnection error Close the socket channel directly if server already mark the end of the channel
Contributor
|
@zhenlineo it would be really nice to have tests for flipping the buffer on connection error and logs for empty |
Contributor
Author
|
@lutovich Logging for this specific best effort channel.close error is not very helpful. As this is not the real error. The error that the driver cannot read/write more data from the channel is the real error that a user should worry about. Whether I close this socket connection correctly or the socket just crashed is not really important as next session, they will get another new connection. |
Contributor
Author
|
@lutovich Be free to find me if you still disagree. I merge this now as it is an important bug fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
that is caused by forgetting to flip a buffer back after connection error.
Close the socket channel directly if server already mark the end of the channel