Fixes to driver #244
Merged
Fixes to driver #244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The same connections was being added to the queue if close was called more than once. Eventually the queue will be full and we close the connection, but since the queue now contains multiple identical copies we will also close these.
pontusmelke
force-pushed
the
1.1-fixup
branch
2 times, most recently
from
614cf13 to
f753d3b
Compare
Instead of guarding in `PooledConnection` as well as in `NetworkSession` we make sure we only close connection once in `RoutingDriver`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ACK_FAILUREis ignoredConnectionFailureException