Remove server when failing on session acquisition #241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pontusmelke
force-pushed
the
1.1-remove-address-on-connection-failure
branch
from
2badccc to
f0045ee
Compare
We were only checking for connection failures on running and consuming the results, however there might also be a connection failure on session acquisition. By not properly removing the server on session-acquisition failures we end up in a scenario where we constantly retry to connect to that endpoint.
pontusmelke
force-pushed
the
1.1-remove-address-on-connection-failure
branch
from
f0045ee to
b4885f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were only checking for connection failures on running and consuming the
results, however there might also be a connection failure on session acquisition.
By not properly removing the server on session-acquisition failures we end up
in a scenario where we constantly retry to connect to that endpoint.