Turn off hostname verification for trustAllCertificates TrustStrategy #1301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Config.TrustStrategy.trustAllCertificates()` should return `TrustStrategy` with hostname verification turned off by default. This update is part of behaviour unification among the official drivers.
AndyHeap-NeoTech
approved these changes
Sep 1, 2022
AndyHeap-NeoTech
left a comment
AndyHeap-NeoTech
left a comment
There was a problem hiding this comment.
The changes look good. Should the security teams advice change the behaviour can easily be re-enabled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Config.TrustStrategy.trustAllCertificates()should returnTrustStrategywith hostname verification turned off by default.This update is part of behaviour unification among the official drivers.