Replace AddressSet with standard Java collections #1037
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
injectives
force-pushed
the
feature/table
branch
4 times, most recently
from
77bec1b to
e75609f
Compare
This update also prevents unnecessary connection pool closures by keeping `disused` addresses until next routing table update and reusing them.
injectives
force-pushed
the
feature/table
branch
from
e75609f to
628acae
Compare
injectives
force-pushed
the
feature/table
branch
from
1f6ef18 to
c27f322
Compare
michael-simons
approved these changes
Oct 19, 2021
Contributor
michael-simons
left a comment
michael-simons
left a comment
There was a problem hiding this comment.
Thanks again for a nice collaboration.
injectives
added a commit
to injectives/neo4j-java-driver
that referenced
this pull request
Oct 29, 2021
* Replace AddressSet with standard Java collections This update also prevents unnecessary connection pool closures by keeping `disused` addresses until next routing table update and reusing them. * Update reader, writer and router addresses handling and change type
injectives
added a commit
that referenced
this pull request
Oct 29, 2021
…alSummaryCounters update and Testkit launch fix (#1052) * Fix sync and async testkit backends launch (#1027) * Add toString to InternalSummaryCounters (#1031) * Make AddressSet retain resolved addresses (#1034) Routing table address set update may override resolved router address. This leads to routing connection pool closures. This update aims to optimise this. * Improve connection pool concurrent access (#1035) This update introduces read/write lock for internal pool map access management. For instance, the `retainAll` method is executed with write lock. * Replace AddressSet with standard Java collections (#1037) * Replace AddressSet with standard Java collections This update also prevents unnecessary connection pool closures by keeping `disused` addresses until next routing table update and reusing them. * Update reader, writer and router addresses handling and change type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update also prevents unnecessary connection pool closures by keeping
disusedaddresses until next routing table update and reusing them.