Server user add UI fixes #974
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linuslundahl
force-pushed
the
fix/server-user-add-ui-fixes
branch
from
5357ef1 to
3a7985f
Compare
oskarhane
reviewed
Sep 30, 2019
|
|
||
| export const StyledFrameAside = styled.div` | ||
| flex: 1 0 25%; | ||
| flex: 0 0 25%; |
Member
There was a problem hiding this comment.
This change is scary. I haven't review it visually yet so it might be fine, but this is a major change. :)
Contributor
Author
There was a problem hiding this comment.
It might look scary, but the Aside (which I added in the major PR we merged a few weeks ago) is not supposed to grow.
linuslundahl
force-pushed
the
fix/server-user-add-ui-fixes
branch
from
9f0da43 to
1ccaa47
Compare
oskarhane
reviewed
Oct 9, 2019
Member
oskarhane
left a comment
oskarhane
left a comment
There was a problem hiding this comment.
Looks good apart from a visual regression as seen in the screenshot.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes some style and UX issues with
server user addandserver user list.Before:
After:
changelog: UI fixes on
:server user addand:server user listcommands