:param v2 #962
Merged
:param v2 #962
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huboneo
force-pushed
the
feature-param-v2
branch
2 times, most recently
from
a999616 to
3d96f89
Compare
huboneo
commented
Aug 27, 2019
| } | ||
|
|
||
| // future proofing | ||
| if (parameters.type !== ARRAY) return null |
oskarhane
reviewed
Aug 30, 2019
Member
oskarhane
left a comment
oskarhane
left a comment
There was a problem hiding this comment.
I love the parser approach on this one. So great not to add more regexps!
Maybe we could think about adding another parser (or extend yours) to parse all :param and :params input? (not now, but might be worth a card).
It seems to have broken e2e tests.
- Added new dep @neo4j/browser-lambda-parser - Updated existing cmd utils to use parser for all things lambda - Standardized and cleaned up error frames appearance regardless of source - Added new help text for :param - Standardized appearance of :help buttons and Error frames
huboneo
force-pushed
the
feature-param-v2
branch
from
ea32325 to
b611283
Compare
Contributor
Author
|
@oskarhane thank you for your feedback! I have addressed your comments. For the AutoExecButton tests I had to export a non-bus version as I could not figure out how to properly mock |
huboneo
force-pushed
the
feature-param-v2
branch
from
5a50a8f to
dbebe24
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the
:paramv2 syntax (explicit returns). In addition, it also cleans up and standardizes the error frame appearance regardless of error origin. Finally it standardizes the appearance of:helpbuttons.Todo
@neo4j/browser-lambda-parseris publishedSTR
:help paramand follow the instructions for explicit returnsScreenshots
Setting parameters
Error
:helpcommandschangelog: Support additional
:paramdefinition. See:help paramsin neo4j-browser for instructions.