Skip to content

Conversation

@huboneo
Copy link
Contributor

@huboneo huboneo commented Aug 9, 2019

This PR makes URLs returned in Graph inspector and Table views clickable (opens new tab).

Screenshots

Screenshot 2019-08-09 at 16 04 39

Screenshot 2019-08-09 at 16 04 46

STR

  • CREATE (n:Stuff {stuff: "http://google.com" tots mgoats workds"})
  • MATCH (n:Stuff) RETURN n
  • click node in graph
  • switch to table view

Todo

  • Add unit tests

@huboneo huboneo requested a review from oskarhane August 9, 2019 14:10
Copy link
Member

@oskarhane oskarhane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, just want the tests to cover more examples.

Copy link
Member

@oskarhane oskarhane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@huboneo huboneo merged commit d74c5d6 into neo4j:master Aug 12, 2019
@huboneo huboneo deleted the clickable-urls branch August 12, 2019 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants