Fix/help keys dark mode #891
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Also adjusts the layout a bit.
* Also adjust file permissions.
oskarhane
reviewed
Jan 3, 2019
Member
oskarhane
left a comment
oskarhane
left a comment
There was a problem hiding this comment.
Great!
Was the chmod changes a mistake or intentional?
Before / after screenshots would be nice, but not super important.
| font-style: normal; | ||
| font-weight: 300; | ||
| src: local('Open Sans'), local('OpenSans'), url('fonts/OpenSans-Light.ttf') format('truetype'); | ||
| src: local('Open Sans Light'), local('OpenSansLight'), url('fonts/OpenSans-Light.ttf') format('truetype'); |
Contributor
Author
|
The Open Sans files had different permissions. Gave them the same permissions as the rest of the fonts to see if that was a factor for Open Sans not loading correctly. Then just left all files with the same permission for consistency. Before: After: |
myzero1
pushed a commit
to myzero1/neo4j-browser
that referenced
this pull request
May 17, 2019
Fix/help keys dark mode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changelog: Fix
:help keysin dark modefixes: #889