Fix :queries frame so that connection errors are displayed
#835
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically deployed with Now. |
myzero1
pushed a commit
to myzero1/neo4j-browser
that referenced
this pull request
May 17, 2019
Fix `:queries` frame so that connection errors are displayed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
In a causal clustered setup when executing the
:queriescommand, the resulting frame displays the records returned from runningcall dbms.listQuerieson all cluster members. If theusernameandpasswordused on the current session are invalid with any of the other cluster members, the frame would throw an error and cause Neo4j Browser to become unresponsive.Fix:
Gracefully handle errors from the individual members and display the error to the user. A more detailed error message is displayed as an error row tooltip.
changelog: Fix crashing
:queriesframe in clustered environments when all members couldn't be reached