Skip to content

Fix issue where action stream was being stored in memory #723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pe4cey merged 3 commits into from
Mar 21, 2018
Merged

Fix issue where action stream was being stored in memory #723

pe4cey merged 3 commits into from
Mar 21, 2018

Conversation

@pe4cey
Copy link
Contributor

@pe4cey pe4cey commented Mar 21, 2018 •
edited by oskarhane
Loading

Removes zip usage from the postConnectCmdEpic.

The usage of zip (in this epic) was storing the complete history of the action stream and causing a memory leak.

changelog: Fix memory leak in background job

@Kmaschta
Copy link

Kmaschta commented Mar 21, 2018

Good catch!

oskarhane
oskarhane reviewed Mar 21, 2018
View reviewed changes
src/shared/modules/commands/commandsDuck.js Outdated
export const postConnectCmdEpic = (some$, store) =>
some$
.zip(some$.ofType(CONNECTION_SUCCESS), some$.ofType(UPDATE_SETTINGS))
.concat(some$.ofType(CONNECTION_SUCCESS), some$.ofType(UPDATE_SETTINGS))
Copy link
Member

@oskarhane oskarhane Mar 21, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we want .merge over concat.

@oskarhane
Copy link
Member

oskarhane commented Mar 21, 2018 •
edited
Loading

After thinking about it, we do not want to execute this on every UPDATE_SETTINGS. We only want to do it once, right after we successfully connected to a database.
So the initial intention is correct, but we didn't know that all settings actions were stored forever.
We just want the latest one, after a CONNECTION_SUCCESS happened.

So the flow is:

CONNECTION_SUCCESS -> UPDATE_SETTINGS -> check for post_connect_cmd and execute it

Not sure how to write that in code yet though.

@oskarhane
Only execute post_connect_cmd when it should
0359b19 
Wait for CONNECTION_SUCCESS and then wait for one SETTINGS_UPDATE and then do the execution
@oskarhane
No need to make a copy of a copy
87adbf9
@pe4cey pe4cey merged commit 30b1163 into neo4j:master Mar 21, 2018
@pe4cey pe4cey deleted the remove-rxjs-zip branch March 21, 2018 16:56
myzero1 pushed a commit to myzero1/neo4j-browser that referenced this pull request May 17, 2019
@pe4cey
Merge pull request neo4j#723 from pe4cey/remove-rxjs-zip
897931b 
Fix issue where action stream was being stored in memory
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oskarhane oskarhane oskarhane left review comments

Assignees

No one assigned

Labels

changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pe4cey @Kmaschta @oskarhane