Read and act on server config retain_connection_credentials #498
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On connect (and at the regular interval) read server config `browser.retain_connection_credentials`. If set to a falsy value, remove persisted connection credentials from web browsers localstorage. Keep in memory to be able to use in a Causal clustered environment where new connections might be opened to run a query on every cluster member (`:queries` for example). Show persist status on the `:server connect` frame.
oskarhane
force-pushed
the
3.0-store-credentials-config
branch
from
8ae0d84 to
ce64e7e
Compare
irfannuri
reviewed
May 18, 2017
| } | ||
|
|
||
| // Local vars | ||
| let memoryUsername = '' |
Contributor
There was a problem hiding this comment.
@oskarhane I am a bit concerned about having those as local variable, although the current lifecycle of duck files are Ok with that. We may have them in redux store but not synced with local storage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On connect (and at the regular interval) read server config
browser.retain_connection_credentials.If set to a falsy value, remove persisted connection credentials from web browsers localstorage.
Keep in memory to be able to use in a Causal clustered environment where new connections might be opened to run a query on every cluster member (
:queriesfor example).Show persist status on the
:server connectframe.Connect when set to false:
and true (default):
