Align text table display of nodes with cypher shell #1879
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eijawerner
requested changes
Jan 26, 2023
There was a problem hiding this comment.
Nice work! ⭐ See review comments for some details to look over. Also I think for these kind of functions with a lot of logic, and since unit tests are rather cheap to run, it would be good to have more unit tests, apart from the path with multiple nodes we talked about, make sure that all paths in the recordToStringArray and stringifyNodeRelationshipOrPath are covered.
src/browser/modules/Stream/CypherFrame/__snapshots__/AsciiView.test.tsx.snap
Outdated
Show resolved
Hide resolved
|
@eijawerner thanks for the review everything is updated now |
noahmay
added a commit
to BjornMagn-Neo4j/neo4j-browser
that referenced
this pull request
Mar 8, 2023
* updates the text table and csv content for cypher frames * fix type error * update unit test * handle cypher map type * fix tests * update e2e test * update e2e test * fix e2e tests * updare snapshot * update ascii view function to map records * fix tests * update after review * missed optional length
OskarDamkjaer
changed the title
OskarDamkjaer
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds labels and types to nodes and relationships respectively in the text table for a cypher frame. This look is more aligned with cypher shell than the previous one which only showed properties.