Make editor commands extendable #1846
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| '!suggestWidgetVisible && !findWidgetVisible' | ||
| ) | ||
|
|
||
| function keys<T>(object: T) { |
There was a problem hiding this comment.
Perhaps move this to the "objectUtils" file?
There was a problem hiding this comment.
Good call, missed that file
Comment on lines
401
to
403
| this?.editor?.addCommand(key, () => { | ||
| command() | ||
| }) |
There was a problem hiding this comment.
Suggested change
| this?.editor?.addCommand(key, () => { | |
| command() | |
| }) | |
| this.editor?.addCommand(key, command) |
would avoid creating an extra function (if it works with the types)
OskarDamkjaer
approved these changes
Nov 7, 2022
noahmay
added a commit
to OskarDamkjaer/neo4j-browser
that referenced
this pull request
Nov 15, 2022
* Make editor commands extendable * update arc version * fixes after review
OskarDamkjaer
added a commit
that referenced
this pull request
Nov 18, 2022
* update driver * Fix unit tests * Fix version issues with new driver * don't show removed field in raw overview * update snapshots * fix urls for loading northwind data (#1831) * support connecting to cluster members missing default database (#1832) * support connecting to cluster members missing default database * Fix slow label data in 3.5 testing * 5.0.0 * Remove padding in viz details pane in arc To allow custom padding when overriding content. Removed PaneContainer since not used. * Fixed broken auto scroll of properties pane (#1836) Also made sure that if there are many labels on one node, that it is scrollable instead of just rendered out of sight. * Add missing space between `connected` and `to` in connection confirmation message. (#1837) * Fix issue with :server user list role when username is an email * Separate metadata count query (#1840) * Seperate metadata count query * Update styles * update snapshots * Update src/browser/modules/DBMSInfo/DBMSInfo.tsx Co-authored-by: Oskar Damkjaer <[email protected]> * Update src/shared/modules/dbMeta/dbMetaDuck.ts Co-authored-by: Oskar Damkjaer <[email protected]> * remove console.log * change name of function * fix spelling Co-authored-by: Oskar Damkjaer <[email protected]> * Composite db didn't show result graph (#1841) * fix composite db blank results * add e2e test for composite db * add 5.1 to e2e tests * fix e2e test * Add optional isExecutable prop to editor if using it in a context where the editor is just used for text input, for example editing a cypher query in a form. * chore(query): check is executable by onExecute prop instead also updated needle deps to match needle used in nx. * Add e2e for node details with lots of props * Test scroll in node properties overview * Make editor commands extendable (#1846) * Make editor commands extendable * update arc version * fixes after review * Add tab index to cypher editor (#1847) * Add tabIndex to cypherEditor props * update arc version * remove argument * update after review * bugfix incorrectly zooms when changing style of graph * make it possible to use Escape key to escape editor (#1849) * Make editor not scrollable (#1850) * make it possible to use Escape key to escape editor * fix scroll in edtior * this maybe fixes it * change comment * fix issue where zooming when expanding node * possible to change message text in copier also adjusted messages to be closer to copy icon to save space if there is shortage of space * update driver to 5.2.0 * update error message check * update test * update test again Co-authored-by: Eija Werner <[email protected]> Co-authored-by: Eija Werner <[email protected]> Co-authored-by: Stefano Ottolenghi <[email protected]> Co-authored-by: Noah Mayerhofer <[email protected]>
noahmay
added a commit
to noahmay/neo4j-browser
that referenced
this pull request
Nov 21, 2022
* update driver * Fix unit tests * Fix version issues with new driver * don't show removed field in raw overview * update snapshots * fix urls for loading northwind data (neo4j#1831) * support connecting to cluster members missing default database (neo4j#1832) * support connecting to cluster members missing default database * Fix slow label data in 3.5 testing * 5.0.0 * Remove padding in viz details pane in arc To allow custom padding when overriding content. Removed PaneContainer since not used. * Fixed broken auto scroll of properties pane (neo4j#1836) Also made sure that if there are many labels on one node, that it is scrollable instead of just rendered out of sight. * Add missing space between `connected` and `to` in connection confirmation message. (neo4j#1837) * Fix issue with :server user list role when username is an email * Separate metadata count query (neo4j#1840) * Seperate metadata count query * Update styles * update snapshots * Update src/browser/modules/DBMSInfo/DBMSInfo.tsx Co-authored-by: Oskar Damkjaer <[email protected]> * Update src/shared/modules/dbMeta/dbMetaDuck.ts Co-authored-by: Oskar Damkjaer <[email protected]> * remove console.log * change name of function * fix spelling Co-authored-by: Oskar Damkjaer <[email protected]> * Composite db didn't show result graph (neo4j#1841) * fix composite db blank results * add e2e test for composite db * add 5.1 to e2e tests * fix e2e test * Add optional isExecutable prop to editor if using it in a context where the editor is just used for text input, for example editing a cypher query in a form. * chore(query): check is executable by onExecute prop instead also updated needle deps to match needle used in nx. * Add e2e for node details with lots of props * Test scroll in node properties overview * Make editor commands extendable (neo4j#1846) * Make editor commands extendable * update arc version * fixes after review * Add tab index to cypher editor (neo4j#1847) * Add tabIndex to cypherEditor props * update arc version * remove argument * update after review * bugfix incorrectly zooms when changing style of graph * make it possible to use Escape key to escape editor (neo4j#1849) * Make editor not scrollable (neo4j#1850) * make it possible to use Escape key to escape editor * fix scroll in edtior * this maybe fixes it * change comment * fix issue where zooming when expanding node * possible to change message text in copier also adjusted messages to be closer to copy icon to save space if there is shortage of space * update driver to 5.2.0 * update error message check * update test * update test again Co-authored-by: Eija Werner <[email protected]> Co-authored-by: Eija Werner <[email protected]> Co-authored-by: Stefano Ottolenghi <[email protected]> Co-authored-by: Noah Mayerhofer <[email protected]>
noahmay
added a commit
to BjornMagn-Neo4j/neo4j-browser
that referenced
this pull request
Mar 8, 2023
* Make editor commands extendable * update arc version * fixes after review
noahmay
added a commit
to BjornMagn-Neo4j/neo4j-browser
that referenced
this pull request
Mar 8, 2023
* update driver * Fix unit tests * Fix version issues with new driver * don't show removed field in raw overview * update snapshots * fix urls for loading northwind data (neo4j#1831) * support connecting to cluster members missing default database (neo4j#1832) * support connecting to cluster members missing default database * Fix slow label data in 3.5 testing * 5.0.0 * Remove padding in viz details pane in arc To allow custom padding when overriding content. Removed PaneContainer since not used. * Fixed broken auto scroll of properties pane (neo4j#1836) Also made sure that if there are many labels on one node, that it is scrollable instead of just rendered out of sight. * Add missing space between `connected` and `to` in connection confirmation message. (neo4j#1837) * Fix issue with :server user list role when username is an email * Separate metadata count query (neo4j#1840) * Seperate metadata count query * Update styles * update snapshots * Update src/browser/modules/DBMSInfo/DBMSInfo.tsx Co-authored-by: Oskar Damkjaer <[email protected]> * Update src/shared/modules/dbMeta/dbMetaDuck.ts Co-authored-by: Oskar Damkjaer <[email protected]> * remove console.log * change name of function * fix spelling Co-authored-by: Oskar Damkjaer <[email protected]> * Composite db didn't show result graph (neo4j#1841) * fix composite db blank results * add e2e test for composite db * add 5.1 to e2e tests * fix e2e test * Add optional isExecutable prop to editor if using it in a context where the editor is just used for text input, for example editing a cypher query in a form. * chore(query): check is executable by onExecute prop instead also updated needle deps to match needle used in nx. * Add e2e for node details with lots of props * Test scroll in node properties overview * Make editor commands extendable (neo4j#1846) * Make editor commands extendable * update arc version * fixes after review * Add tab index to cypher editor (neo4j#1847) * Add tabIndex to cypherEditor props * update arc version * remove argument * update after review * bugfix incorrectly zooms when changing style of graph * make it possible to use Escape key to escape editor (neo4j#1849) * Make editor not scrollable (neo4j#1850) * make it possible to use Escape key to escape editor * fix scroll in edtior * this maybe fixes it * change comment * fix issue where zooming when expanding node * possible to change message text in copier also adjusted messages to be closer to copy icon to save space if there is shortage of space * update driver to 5.2.0 * update error message check * update test * update test again Co-authored-by: Eija Werner <[email protected]> Co-authored-by: Eija Werner <[email protected]> Co-authored-by: Stefano Ottolenghi <[email protected]> Co-authored-by: Noah Mayerhofer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the toggleFullscreen prop on the editor and makes commands from Monaco extendable. This way the escape key can be bound to anything.