Zoom out behaviour with fit to zoom #1790
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noahmay
added a commit
to noahmay/neo4j-browser
that referenced
this pull request
Aug 4, 2022
Disables zoom in and out buttons when reaching min/max zoom.
noahmay
added a commit
that referenced
this pull request
Aug 4, 2022
* Visualization zooms to cusor * Prevent 5.0 flakyness from async db creation (#1786) * Add util fn for properly creating databases to avoid flakyness from slow database creations * Run run multidb tests only on dbs with full SHOW DATABASE command * Get rid of jfrog (#1788) * Fix bug with incorrect version number & add git hash to overview (#1791) * Fix bug with incorrect version number & add git hash to overview * Inject instead of fetching * Remove dynamic import (#1787) * Remove dynamic import * Help typescript along * update tests * Adds background for usage of wheelDelta * Update viz.spec.ts * Include data cleanup in test * Zoom out behaviour with fit to zoom (#1790) Disables zoom in and out buttons when reaching min/max zoom. * remove it.only from test case Co-authored-by: Oskar Damkjaer <[email protected]> Co-authored-by: Oskar Damkjaer <[email protected]>
noahmay
added a commit
to OskarDamkjaer/neo4j-browser
that referenced
this pull request
Aug 22, 2022
Disables zoom in and out buttons when reaching min/max zoom.
noahmay
added a commit
to OskarDamkjaer/neo4j-browser
that referenced
this pull request
Aug 22, 2022
* Visualization zooms to cusor * Prevent 5.0 flakyness from async db creation (neo4j#1786) * Add util fn for properly creating databases to avoid flakyness from slow database creations * Run run multidb tests only on dbs with full SHOW DATABASE command * Get rid of jfrog (neo4j#1788) * Fix bug with incorrect version number & add git hash to overview (neo4j#1791) * Fix bug with incorrect version number & add git hash to overview * Inject instead of fetching * Remove dynamic import (neo4j#1787) * Remove dynamic import * Help typescript along * update tests * Adds background for usage of wheelDelta * Update viz.spec.ts * Include data cleanup in test * Zoom out behaviour with fit to zoom (neo4j#1790) Disables zoom in and out buttons when reaching min/max zoom. * remove it.only from test case Co-authored-by: Oskar Damkjaer <[email protected]> Co-authored-by: Oskar Damkjaer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Zoom in and out buttons are now disabled when reach max/min zoom. This fixes and issue when the zoom to fit sets a lower zoom scale than min zoom scale which made the zoom out button zoom in to min zoom scale. Also updates the min zoom scale on zoom to fit.