Skip to content

Conversation

@OskarDamkjaer
Copy link
Contributor

@OskarDamkjaer OskarDamkjaer commented Jan 19, 2021

No preview link as they need to run on aura to notice the difference. To test, hard-code the getEnv in appDuck to CLOUD.

Changes:

  • Disables test that uses bolt as it's not available on aura.
  • Guesses the server version when on aura.
  • Disables user management frames on aura until we have a way to differentiate Professional and Enterprise on aura. See pictures for fallback.

CleanShot 2021-01-19 at 12 33 31@2x

changelog: Update how browser detects and behaves in different environments (Aura)

@OskarDamkjaer OskarDamkjaer changed the title Aura fix Aura version fixes Jan 19, 2021
Copy link
Member

@oskarhane oskarhane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but looks like you refactored but didn't use the new component :)

Comment on lines 1 to 22
import React from 'react'

export default function UserManagementOnAura(): JSX.Element {
return (
<div>
<p>
User management is currently only available through cypher commands on
Neo4j Aura Enterprise.
</p>
<p>
Read more on user and role management with cypher on{' '}
<a
href="https://neo4j.com/docs/cypher-manual/current/administration/security/users-and-roles"
target="_blank"
rel="noreferrer"
>
the Neo4j Cypher docs.
</a>
</p>
</div>
)
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you're not using this new component?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I made that one first but decided not to use it

Copy link
Member

@oskarhane oskarhane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🦩

@OskarDamkjaer OskarDamkjaer merged commit 9ab8bbe into neo4j:master Jan 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants