Use Monaco as the main cypher editor #1248
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Manually built preview 🎉 |
Contributor
OskarDamkjaer
left a comment
OskarDamkjaer
left a comment
There was a problem hiding this comment.
Nice work! Looking forward to having this in master!
Contributor
|
I found some odd behaviour with history, sent you a video on slack. Also I think it'd be good to keep the old blinking cursor color if possible. |
* Add watchers on resize * Reduce unneeded rerenders
OskarDamkjaer
approved these changes
Dec 15, 2020
added 5 commits
December 15, 2020 14:28
Member
|
|
* built-inbetter * Use sort-text workaround to show relevant suggestions and improve small icon
# Conflicts: # src/browser/modules/Editor/Codemirror.tsx # src/browser/modules/Editor/Editor.tsx # src/browser/styles/global-styles.ts
…le letter variables as numbers
# Conflicts: # LICENSES.txt # NOTICE.txt
yarn start currently fails due to relate-by-ui code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the main cypher editor to use Monaco instead of Code Mirror.
The Monaco component that is currently used in the
:editframe is updated to include all functionality that the current cypher editor has (e.g. command history, display current DB, keybindings for run, newline, fullscreen and focus).Monaco also includes some functionality that should be familiar to VS Code users such as selection commands, edit commands and code folding.
changelog: Introducing new editor powered by Monaco