Initial Monaco Editor implementation #1213
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I will be adding tests while the PR is in review |
oskarhane
approved these changes
Oct 13, 2020
Member
oskarhane
left a comment
oskarhane
left a comment
There was a problem hiding this comment.
This is a very good step, really cool to see it in action!
The only thing I don't really like is the additions to FrameTitlebar, but that whole architecture should be reconsidered at some point. 🐳
…king setting on and off
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new cypher editor, made with the Monaco editor. It also adds an
:editcommand that instantiates the new editor inside a frame in the stream so the new editor can be tested before it replaces the current editor.The new editor displays warnings from explain queries or from trying to use multi-statement queries as squiggly underlines with more info on hover.
The new editor tokenizes cypher as the current one and has syntax highlighting in dark and light mode.
Autocompleting cypher is not yet implemented in the moncao editor.