Card view #1155
Merged
Card view #1155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HerrEmil
reviewed
Aug 4, 2020
| ${props => (props.expanded ? '' : 'transition-duration: 0.1s;')} | ||
| .CodeMirror { | ||
| background-color: ${props => props.theme.editorBackground} !important; |
Contributor
Author
There was a problem hiding this comment.
Should be fixed now:
I do think the dark mode editor is too black, it could be the same color as the frames? Also, the header color doesn't fit as well in dark mode either
Contributor
There was a problem hiding this comment.
Both light and dark mode look correct to me on Windows :)
OskarDamkjaer
force-pushed
the
card_view
branch
from
63c2fd7 to
e705248
Compare
Contributor
Author
|
@HerrEmil Mergeable now? :) |
HerrEmil
approved these changes
Aug 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR moves buttons inside editor like so:
Multiline now looks:
Full screen is really fullscreen:
Current multiline for reference:
Colors, transitions, positioning, icons and other cosmetics still need more work though.
The gifs' framerate is to low to give it justice but there are some transitions: http://g.recordit.co/akBSL40Dhs.gif
changelog: Improve editor view sizes (single-line, card view and fullscreen)