Skip to content

Commit 02f51fd

Browse files
committed
fix review
1 parent bfa05d6 commit 02f51fd

File tree

6 files changed

+21
-39
lines changed

6 files changed

+21
-39
lines changed

src/browser/modules/DBMSInfo/DatabaseSelector.tsx

Lines changed: 13 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -95,35 +95,19 @@ export const DatabaseSelector = ({
9595
<option value={EMPTY_OPTION}>{EMPTY_OPTION}</option>
9696
)}
9797

98-
{databasesAndAliases.map(dbOrAlias => {
99-
//If alias
100-
if ('databaseName' in dbOrAlias) {
101-
return (
102-
<option
103-
key={dbOrAlias.name}
104-
value={dbOrAlias.databaseName}
105-
disabled={dbOrAlias.status === 'unknown'}
106-
>
107-
{dbOrAlias.name}
108-
</option>
109-
)
110-
}
111-
112-
//If database
113-
return (
114-
<option
115-
key={dbOrAlias.name}
116-
value={dbOrAlias.name}
117-
disabled={dbOrAlias.status === 'unknown'}
118-
>
119-
{dbOrAlias.name}
120-
{dbOrAlias === homeDb ? NBSP_CHAR + HOUSE_EMOJI : ''}
121-
{dbOrAlias.status === 'unknown'
122-
? NBSP_CHAR + HOUR_GLASS_EMOJI
123-
: ''}
124-
</option>
125-
)
126-
})}
98+
{databasesAndAliases.map(dbOrAlias => (
99+
<option
100+
key={dbOrAlias.name}
101+
value={dbOrAlias.name}
102+
disabled={dbOrAlias.status === 'unknown'}
103+
>
104+
{dbOrAlias.name}
105+
{dbOrAlias === homeDb ? NBSP_CHAR + HOUSE_EMOJI : ''}
106+
{dbOrAlias.status === 'unknown'
107+
? NBSP_CHAR + HOUR_GLASS_EMOJI
108+
: ''}
109+
</option>
110+
))}
127111
</Select>
128112
</DrawerSectionBody>
129113
</DrawerSection>

src/browser/modules/Stream/CypherFrame/CodeView.tsx

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -94,6 +94,10 @@ export class CodeViewComponent extends Component<any> {
9494
<PaddedDiv>
9595
<StyledTable>
9696
<StyledTBody>
97+
<StyledAlteringTr>
98+
<StyledStrongTd>Server version</StyledStrongTd>
99+
<StyledTd>{request.result.summary.server.agent}</StyledTd>
100+
</StyledAlteringTr>
97101
<StyledAlteringTr>
98102
<StyledStrongTd>Server address</StyledStrongTd>
99103
<StyledTd>{request.result.summary.server.address}</StyledTd>

src/neo4j-arc/cypher-language-support/cypher-editor/CypherEditor.tsx

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -46,10 +46,6 @@ const MonacoStyleWrapper = styled.div`
4646
.hover-row.status-bar {
4747
display: none !important;
4848
}
49-
// used to make the focus outline of the editor not be ugly. Don't think this breaks anything
50-
.monaco-editor.rename-box {
51-
display: none;
52-
}
5349
`
5450

5551
const EXPLAIN_QUERY_PREFIX = 'EXPLAIN '

src/neo4j-arc/package.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@neo4j-devtools/arc",
3-
"version": "0.0.42",
3+
"version": "0.0.43",
44
"main": "dist/neo4j-arc.js",
55
"author": "Neo4j Inc.",
66
"license": "GPL-3.0",
@@ -26,7 +26,7 @@
2626
"@rollup/plugin-alias": "^3.1.9",
2727
"@types/react": "^17.0.40",
2828
"esbuild": "^0.14.26",
29-
"neo4j-driver-core": "^5.0.1",
29+
"neo4j-driver-core": "^5.2.0",
3030
"react": "^17.0.2",
3131
"react-dom": "^17.0.2",
3232
"rollup": "^2.70.1",
@@ -68,7 +68,7 @@
6868
"peerDependencies": {
6969
"@neo4j-ndl/base": "^0.1.2",
7070
"@neo4j-ndl/react": "^0.1.2",
71-
"neo4j-driver-core": "^5.0.1",
71+
"neo4j-driver-core": "^5.2.0",
7272
"react": "^17.0.2",
7373
"react-dom": "^17.0.2"
7474
}

src/neo4j-arc/yarn.lock

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1280,7 +1280,7 @@ nano-css@^5.3.1:
12801280
stacktrace-js "^2.0.2"
12811281
stylis "^4.0.6"
12821282

1283-
neo4j-driver-core@^5.0.1:
1283+
neo4j-driver-core@^5.2.0:
12841284
version "5.2.0"
12851285
resolved "https://registry.yarnpkg.com/neo4j-driver-core/-/neo4j-driver-core-5.2.0.tgz#b465bea6580196f43945265b75961978de17e39e"
12861286
integrity sha512-USdA9u+V0VM7y4UwH4nrofBaROwp73iKx1hC6TNWQRKF5o7biDUt6Wc1x3+oO4YN4lCSC5JzB/tHlG4f1cYxsg==

src/shared/modules/dbMeta/utils.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,8 +46,6 @@ export function extractServerInfo(res: QueryResult): ServerInfo {
4646
serverInfo.edition = resultObj.edition
4747
}
4848

49-
// TODO se till att få rätt på den där temporära vesionummerna
50-
5149
// Get server edition if available
5250
if (res.records.length && res.records[0].keys.includes('edition')) {
5351
serverInfo.edition = res.records[0].get('edition')

0 commit comments

Comments
 (0)