Skip to content

Commit bfa05d6

Browse files
authored
change scroll into view selector (#1864)
1 parent f1fe810 commit bfa05d6

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

e2e_tests/integration/viz.spec.ts

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -267,8 +267,9 @@ describe('Viz rendering', () => {
267267

268268
// Check that can scroll overview panel
269269
const showAllButtonText = 'Show all'
270-
cy.get(`button:contains("${showAllButtonText}")`).scrollIntoView()
271-
cy.get(`button:contains("${showAllButtonText}")`).should('be.visible')
270+
cy.get(`button:contains("${showAllButtonText}")`)
271+
.scrollIntoView()
272+
.should('be.visible')
272273

273274
// Open node properties details panel
274275
const nodeSelector = '.node'
@@ -282,7 +283,7 @@ describe('Viz rendering', () => {
282283
cy.contains(lastPropName).should('exist')
283284

284285
// For some reason need to get to the td to be able to scroll to it, hence the parent()
285-
cy.get('tr td span').contains(lastPropName).parent().scrollIntoView()
286+
cy.get('[data-testid="viz-details-pane-body"]').scrollTo('bottom')
286287
cy.get('tr td span').contains(lastPropName).should('be.visible')
287288
})
288289
})

src/browser/modules/Stream/CypherFrame/VisualizationView/PropertiesPanelContent/DetailsPane.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ export function DetailsPane({
8686
)
8787
})}
8888
</PaneHeader>
89-
<PaneBody>
89+
<PaneBody data-testid="viz-details-pane-body">
9090
<PropertiesTable
9191
visibleProperties={visibleItemProperties}
9292
onMoreClick={handleMorePropertiesClick}

0 commit comments

Comments
 (0)