Skip to content

[Snyk] Upgrade @testing-library/jest-dom from 5.16.5 to 5.17.0 #491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Snyk] Upgrade @testing-library/jest-dom from 5.16.5 to 5.17.0 #491

wants to merge 1 commit into from

Conversation

nejidevelops
Copy link
Owner

snyk-top-banner

Snyk has created this PR to upgrade @testing-library/jest-dom from 5.16.5 to 5.17.0.

ℹ️ Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.

  • The recommended version is 1 version ahead of your current version.

  • The recommended version was released 2 years ago.

Issues fixed by the recommended upgrade:

Issue Score Exploit Maturity
critical severity Predictable Value Range from Previous Values
SNYK-JS-FORMDATA-10841150		 791 Proof of Concept
high severity Denial of Service (DoS)
SNYK-JS-HTTPPROXYMIDDLEWARE-8229906		 791 Proof of Concept
high severity Denial of Service (DoS)
SNYK-JS-WS-7266574		 791 Proof of Concept
high severity Denial of Service (DoS)
SNYK-JS-WS-7266574		 791 Proof of Concept
high severity Server-side Request Forgery (SSRF)
SNYK-JS-IP-12704893		 791 Proof of Concept
high severity Server-side Request Forgery (SSRF)
SNYK-JS-IP-12761655		 791 Proof of Concept
high severity Server-side Request Forgery (SSRF)
SNYK-JS-IP-6240864		 791 Proof of Concept
high severity Prototype Pollution
SNYK-JS-LOADERUTILS-3043105		 791 No Known Exploit
high severity Code Injection
SNYK-JS-LODASHTEMPLATE-1088054		 791 Proof of Concept
high severity Prototype Pollution
SNYK-JS-MERGE-1040469		 791 No Known Exploit
high severity Prototype Pollution
SNYK-JS-MERGE-1042987		 791 Proof of Concept
high severity Improper Verification of Cryptographic Signature
SNYK-JS-NODEFORGE-2430339		 791 No Known Exploit
high severity Regular Expression Denial of Service (ReDoS)
SNYK-JS-ANSIHTML-1296849		 791 Proof of Concept
high severity Asymmetric Resource Consumption (Amplification)
SNYK-JS-BODYPARSER-7926860		 791 No Known Exploit
high severity Excessive Platform Resource Consumption within a Loop
SNYK-JS-BRACES-6838727		 791 Proof of Concept
high severity Excessive Platform Resource Consumption within a Loop
SNYK-JS-BRACES-6838727		 791 Proof of Concept
medium severity Regular Expression Denial of Service (ReDoS)
SNYK-JS-GLOBPARENT-1016905		 791 Proof of Concept
medium severity Regular Expression Denial of Service (ReDoS)
SNYK-JS-HTMLMINIFIER-3091181		 791 Proof of Concept
medium severity Regular Expression Denial of Service (ReDoS)
SNYK-JS-LOADERUTILS-3042992		 791 No Known Exploit
medium severity Open Redirect
SNYK-JS-NODEFORGE-2330875		 791 Proof of Concept
medium severity Improper Verification of Cryptographic Signature
SNYK-JS-NODEFORGE-2430337		 791 No Known Exploit
low severity Regular Expression Denial of Service (ReDoS)
SNYK-JS-WORDWRAP-3149973		 791 Proof of Concept
critical severity Generation of Predictable Numbers or Identifiers
SNYK-JS-PBKDF2-10495496		 791 Proof of Concept
critical severity Generation of Predictable Numbers or Identifiers
SNYK-JS-PBKDF2-10495498		 791 No Known Exploit
high severity Excessive Platform Resource Consumption within a Loop
SNYK-JS-BRACES-6838727		 791 Proof of Concept
high severity Improper Verification of Cryptographic Signature
SNYK-JS-BROWSERIFYSIGN-6037026		 791 No Known Exploit
high severity Regular Expression Denial of Service (ReDoS)
SNYK-JS-CROSSSPAWN-8303230		 791 Proof of Concept
high severity Improper Verification of Cryptographic Signature
SNYK-JS-ELLIPTIC-8172694		 791 No Known Exploit
high severity Path Traversal
SNYK-JS-WEBPACKDEVMIDDLEWARE-6476555		 791 Proof of Concept
medium severity Regular Expression Denial of Service (ReDoS)
SNYK-JS-POSTCSS-1255640		 791 Proof of Concept
medium severity Prototype Pollution
SNYK-JS-YARGSPARSER-560381		 791 Proof of Concept
medium severity Prototype Pollution
SNYK-JS-YARGSPARSER-560381		 791 Proof of Concept
medium severity Server-Side Request Forgery (SSRF)
SNYK-JS-IP-7148531		 791 Proof of Concept
medium severity Reverse Tabnabbing
SNYK-JS-ISTANBULREPORTS-2328088		 791 No Known Exploit
medium severity Prototype Pollution
SNYK-JS-JSON5-3182856		 791 Proof of Concept
medium severity Regular Expression Denial of Service (ReDoS)
SNYK-JS-LOADERUTILS-3105943		 791 No Known Exploit
medium severity Inefficient Regular Expression Complexity
SNYK-JS-MICROMATCH-6838728		 791 No Known Exploit
medium severity Inefficient Regular Expression Complexity
SNYK-JS-MICROMATCH-6838728		 791 No Known Exploit
medium severity Inefficient Regular Expression Complexity
SNYK-JS-MICROMATCH-6838728		 791 No Known Exploit
medium severity Regular Expression Denial of Service (ReDoS)
SNYK-JS-MINIMATCH-3050818		 791 No Known Exploit
medium severity Prototype Pollution
SNYK-JS-NODEFORGE-2331908		 791 No Known Exploit
critical severity Incomplete List of Disallowed Inputs
SNYK-JS-BABELTRAVERSE-5962462		 791 Proof of Concept
critical severity Incomplete List of Disallowed Inputs
SNYK-JS-BABELTRAVERSE-5962463		 791 Proof of Concept
medium severity Improper Verification of Cryptographic Signature
SNYK-JS-NODEFORGE-2430341		 791 No Known Exploit
medium severity Improper Handling of Unexpected Data Type
SNYK-JS-ONHEADERS-10773729		 791 No Known Exploit
medium severity Regular Expression Denial of Service (ReDoS)
SNYK-JS-PATHTOREGEXP-7925106		 791 Proof of Concept
medium severity Regular Expression Denial of Service (ReDoS)
SNYK-JS-PATHTOREGEXP-8482416		 791 Proof of Concept
medium severity Regular Expression Denial of Service (ReDoS)
SNYK-JS-BROWSERSLIST-1090194		 791 Proof of Concept
critical severity Function Call With Incorrect Argument Type
SNYK-JS-CIPHERBASE-12084814		 791 Proof of Concept
medium severity Cross-site Scripting (XSS)
SNYK-JS-COOKIE-8163060		 791 No Known Exploit
critical severity Improper Verification of Cryptographic Signature
SNYK-JS-ELLIPTIC-7577916		 791 Proof of Concept
critical severity Improper Verification of Cryptographic Signature
SNYK-JS-ELLIPTIC-7577917		 791 Proof of Concept
critical severity Improper Verification of Cryptographic Signature
SNYK-JS-ELLIPTIC-7577918		 791 Proof of Concept
critical severity Improper Verification of Cryptographic Signature
SNYK-JS-ELLIPTIC-8187303		 791 Proof of Concept
critical severity Information Exposure
SNYK-JS-ELLIPTIC-8720086		 791 Proof of Concept
high severity Improper Handling of Extra Parameters
SNYK-JS-FOLLOWREDIRECTS-6141137		 791 Proof of Concept
high severity Cross-site Scripting (XSS)
SNYK-JS-SERIALIZEJAVASCRIPT-536840		 791 No Known Exploit
high severity Arbitrary Code Injection
SNYK-JS-SERIALIZEJAVASCRIPT-570062		 791 Proof of Concept
high severity Cross-site Scripting (XSS)
SNYK-JS-SERIALIZEJAVASCRIPT-6056521		 791 No Known Exploit
medium severity Open Redirect
SNYK-JS-EXPRESS-6474509		 791 No Known Exploit
medium severity Cross-site Scripting
SNYK-JS-EXPRESS-7926867		 791 No Known Exploit
medium severity Information Exposure
SNYK-JS-FOLLOWREDIRECTS-6444610		 791 Proof of Concept
critical severity Predictable Value Range from Previous Values
SNYK-JS-FORMDATA-10841150		 791 Proof of Concept
high severity Remote Code Execution (RCE)
SNYK-JS-SHELLQUOTE-1766506		 791 No Known Exploit
high severity Regular Expression Denial of Service (ReDoS)
SNYK-JS-SSRI-1246392		 791 Proof of Concept
high severity Prototype Pollution
SNYK-JS-UNSETVALUE-2400660		 791 No Known Exploit
medium severity Regular Expression Denial of Service (ReDoS)
SNYK-JS-PROMPTS-1729737		 791 Proof of Concept
medium severity Command Injection
SNYK-JS-REACTDEVUTILS-1083268		 791 Proof of Concept
medium severity Server-side Request Forgery (SSRF)
SNYK-JS-REQUEST-3361831		 791 Proof of Concept
medium severity Denial of Service (DoS)
SNYK-JS-SOCKJS-575261		 791 Proof of Concept
medium severity Regular Expression Denial of Service (ReDoS)
SNYK-JS-TERSER-2806366		 791 No Known Exploit
medium severity Symlink Attack
SNYK-JS-TMP-11501554		 791 Proof of Concept
medium severity Prototype Pollution
SNYK-JS-TOUGHCOOKIE-5672873		 791 Proof of Concept
medium severity Prototype Pollution
SNYK-JS-TOUGHCOOKIE-5672873		 791 Proof of Concept
medium severity Regular Expression Denial of Service (ReDoS)
SNYK-JS-UGLIFYJS-1727251		 791 No Known Exploit
medium severity Cross-site Scripting (XSS)
SNYK-JS-WEBPACK-7840298		 791 Proof of Concept
low severity Regular Expression Denial of Service (ReDoS)
npm:braces:20180219		 791 Proof of Concept
low severity Cross-site Scripting
SNYK-JS-SEND-7926862		 791 No Known Exploit
low severity Cross-site Scripting
SNYK-JS-SERVESTATIC-7926865		 791 No Known Exploit
critical severity Function Call With Incorrect Argument Type
SNYK-JS-SHAJS-12089400		 791 Proof of Concept
Release notes
Package name: @testing-library/jest-dom from @testing-library/jest-dom GitHub release notes

Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • This PR was automatically created by Snyk using the credentials of a real user.
  • Max score is 1000. Note that the real score may have changed since the PR was raised.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.

For more information:

@snyk-bot
fix: upgrade @testing-library/jest-dom from 5.16.5 to 5.17.0
d241030 
Snyk has created this PR to upgrade @testing-library/jest-dom from 5.16.5 to 5.17.0.

See this package in npm:
@testing-library/jest-dom

See this project in Snyk:
https://app.snyk.io/org/mohammadnewton/project/22edd24b-54ca-4e0b-a30b-3a42f37de584?utm_source=github&utm_medium=referral&page=upgrade-pr
@gemini-code-assist Gemini Code Assist
Copy link

Summary of Changes

Hello @nejidevelops, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request, automatically generated by Snyk, updates the @testing-library/jest-dom dependency to its latest version, 5.17.0. This upgrade is crucial for enhancing the project's security posture by resolving a multitude of identified vulnerabilities, ranging from critical to low severity. Additionally, it brings in new features and improvements from the updated library version, specifically a new accessible error message matcher.

Highlights

  • Dependency Upgrade: The @testing-library/jest-dom package has been upgraded from version 5.16.5 to 5.17.0.
  • Vulnerability Resolution: This upgrade addresses a significant number of security vulnerabilities, including several critical and high-severity issues identified by Snyk, improving the project's security posture.
  • New Feature: Version 5.17.0 introduces a new toHaveAccessibleErrorMessage feature, which provides a better implementation of the specification and deprecates the older toHaveErrorMessage.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Oct 18, 2025
View reviewed changes
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request upgrades @testing-library/jest-dom, which is an important security update. While the upgrade is correct, I noticed that this testing dependency is listed in dependencies. For better project structure and to avoid including development packages in production builds, it should be in devDependencies. I've left a specific comment with this feedback.

0x01-react_intro/task_3/dashboard/package.json
"private": true,
"dependencies": {
"@testing-library/jest-dom": "^5.16.4",
"@testing-library/jest-dom": "^5.17.0",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This testing library should be in devDependencies, not dependencies, as it's not needed for the production application.

Additionally, it appears this dependency (and others from @testing-library) might be unused. The project's tests seem to use enzyme, and there's no import for @testing-library/jest-dom in setupTests.js.

Please consider either:

  1. Moving it to devDependencies if it is used.
  2. Removing it completely if it is not used.

This also applies to @testing-library/react and @testing-library/user-event.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nejidevelops @snyk-bot