-
Notifications
You must be signed in to change notification settings - Fork 0
[Snyk] Upgrade @testing-library/jest-dom from 5.16.5 to 5.17.0 #470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Snyk has created this PR to upgrade @testing-library/jest-dom from 5.16.5 to 5.17.0. See this package in npm: @testing-library/jest-dom See this project in Snyk: https://app.snyk.io/org/newtonombese1/project/0dbeb3c7-0f2b-4df0-ac5a-fd0108caddf4?utm_source=github&utm_medium=referral&page=upgrade-pr
Summary of ChangesHello @nejidevelops, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request, automatically generated by Snyk, updates the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request, automatically generated by Snyk, upgrades the @testing-library/jest-dom
package to version 5.17.0
. This is a valuable update as it addresses numerous security vulnerabilities. The change itself is correct, and I have one recommendation to improve the project's dependency management.
"private": true, | ||
"dependencies": { | ||
"@testing-library/jest-dom": "^5.16.4", | ||
"@testing-library/jest-dom": "^5.17.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While the version upgrade is correct, this package is a testing library and should be in devDependencies
rather than dependencies
. Placing testing-related libraries in devDependencies
is a best practice that prevents them from being installed in a production environment (e.g., when running npm install --production
). I recommend moving @testing-library/jest-dom
, as well as @testing-library/react
and @testing-library/user-event
, to the devDependencies
section.
Snyk has created this PR to upgrade @testing-library/jest-dom from 5.16.5 to 5.17.0.
ℹ️ Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.
The recommended version is 1 version ahead of your current version.
The recommended version was released 2 years ago.
Issues fixed by the recommended upgrade:
SNYK-JS-CROSSSPAWN-8303230
SNYK-JS-ELLIPTIC-8172694
SNYK-JS-ONHEADERS-10773729
SNYK-JS-PATHTOREGEXP-7925106
SNYK-JS-PATHTOREGEXP-8482416
SNYK-JS-COOKIE-8163060
SNYK-JS-WORDWRAP-3149973
SNYK-JS-FORMDATA-10841150
SNYK-JS-CIPHERBASE-12084814
SNYK-JS-ELLIPTIC-7577916
SNYK-JS-ELLIPTIC-7577917
SNYK-JS-ELLIPTIC-7577918
SNYK-JS-ELLIPTIC-8187303
SNYK-JS-PBKDF2-10495496
SNYK-JS-PBKDF2-10495498
SNYK-JS-SERIALIZEJAVASCRIPT-536840
SNYK-JS-SERIALIZEJAVASCRIPT-570062
SNYK-JS-SERIALIZEJAVASCRIPT-6056521
SNYK-JS-SHELLQUOTE-1766506
SNYK-JS-SSRI-1246392
SNYK-JS-UNSETVALUE-2400660
SNYK-JS-WEBPACKDEVMIDDLEWARE-6476555
SNYK-JS-ANSIHTML-1296849
SNYK-JS-POSTCSS-1255640
SNYK-JS-PROMPTS-1729737
SNYK-JS-REACTDEVUTILS-1083268
SNYK-JS-REQUEST-3361831
SNYK-JS-SOCKJS-575261
SNYK-JS-TERSER-2806366
SNYK-JS-TMP-11501554
SNYK-JS-TOUGHCOOKIE-5672873
SNYK-JS-TOUGHCOOKIE-5672873
SNYK-JS-UGLIFYJS-1727251
SNYK-JS-WEBPACK-7840298
SNYK-JS-EXPRESS-6474509
SNYK-JS-SEND-7926862
SNYK-JS-SERVESTATIC-7926865
SNYK-JS-SHAJS-12089400
SNYK-JS-ELLIPTIC-8720086
SNYK-JS-FOLLOWREDIRECTS-6141137
SNYK-JS-FOLLOWREDIRECTS-6444610
SNYK-JS-FORMDATA-10841150
SNYK-JS-BABELTRAVERSE-5962462
SNYK-JS-WS-7266574
SNYK-JS-WS-7266574
SNYK-JS-BRACES-6838727
SNYK-JS-BROWSERIFYSIGN-6037026
SNYK-JS-HTTPPROXYMIDDLEWARE-8229906
SNYK-JS-IP-12704893
SNYK-JS-IP-12761655
SNYK-JS-YARGSPARSER-560381
SNYK-JS-YARGSPARSER-560381
SNYK-JS-BABELTRAVERSE-5962463
SNYK-JS-BODYPARSER-7926860
SNYK-JS-BRACES-6838727
SNYK-JS-BRACES-6838727
SNYK-JS-IP-6240864
SNYK-JS-LOADERUTILS-3043105
SNYK-JS-LODASHTEMPLATE-1088054
SNYK-JS-MERGE-1040469
SNYK-JS-MERGE-1042987
SNYK-JS-NODEFORGE-2430339
SNYK-JS-EXPRESS-7926867
SNYK-JS-BROWSERSLIST-1090194
SNYK-JS-GLOBPARENT-1016905
SNYK-JS-HTMLMINIFIER-3091181
SNYK-JS-IP-7148531
SNYK-JS-ISTANBULREPORTS-2328088
SNYK-JS-JSON5-3182856
SNYK-JS-LOADERUTILS-3042992
SNYK-JS-LOADERUTILS-3105943
SNYK-JS-MICROMATCH-6838728
SNYK-JS-MICROMATCH-6838728
SNYK-JS-MICROMATCH-6838728
SNYK-JS-MINIMATCH-3050818
SNYK-JS-NODEFORGE-2330875
SNYK-JS-NODEFORGE-2331908
SNYK-JS-NODEFORGE-2430337
SNYK-JS-NODEFORGE-2430341
npm:braces:20180219
Release notes
Package name: @testing-library/jest-dom
5.17.0 (2023-07-18)
Features
toHaveAccessibleErrorMessage
better implementing the spec, deprecatetoHaveErrorMessage
(#503) (d717c66)5.16.5 (2022-08-04)
Bug Fixes
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information: