Skip to content

Bug fixes + Feature implementations #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nectarboy merged 26 commits into from
Dec 31, 2024
Merged

Bug fixes + Feature implementations #1

nectarboy merged 26 commits into from
Dec 31, 2024

Conversation

@nectarboy
Copy link
Owner

@nectarboy nectarboy commented Dec 19, 2024 •
edited
Loading

This WIP pull request aims to fix bugs and implement missing features in the player, as well as extend existing functionality mostly to allow SSAR playback.

Implemented features:

  • the ability to playback SSARs, as well as several features that were needed to correctly play most SSAR sequences, including tie, mono, loop, portamento, etc, have been implemented.
    Bug fixes:
  • many bugs have been fixed, and the player has been tested with against Nintendo's SoundPlayer SDK tool to ensure playback is as accurate as possible (as far as i can percieve).
    Frontend features:
  • the frontend has been given the ability to playback and export SSAR sequences.

What still needs fixing:

  • The piano preview on the side doesn't respond to input anymore for some reason
  • The fullscreen preview doesn't work after a while, unsure if this is a result of my changes
  • The code needs a bit of clean up
  • The existing pan delay feature caused issues with some sounds so it is disabled for now
  • Missing features (PSG and white noise, LFO volume and pan) still need to be implemented.

@nectarboy
Implemented "Tie-in" functionality + a few misc fixes
ef7281f 
* A sequence using bank 0 no longer causes an exception
* Mono mode is now set to true by default, i think this is the correct behavior
@nectarboy
Implemented PitchSweep & Portamento (may still be buggy) + misc fixes
0cce543 
* Fixed pitch bend sign extension
* Tie commands now stop all of a track's active channels (on or off)
@nectarboy
Partially implemented random and variable sequence commands (only lik…
9a9669b 
…e 2 opcodes work with them atm because laziness)
@nectarboy
Fixed the way duration 0 notes behave
0ab579a 
a note with duration 0, mono or not, will have the note play until its sample ends (or forever if the sample loops) (source: Nintendo's own documentation)
a note with duration 0 when mono, will have the same as above occur, but will also have the track rest until that note channel, and no other channel, ends.
this fixes the NSMB Wanted minigame voice clip echoes [NCS_SE_MGT_LUIGI_RIGHT_M0 (ID: 75) and etc]
@nectarboy
Fixed an issue where playing a note then switching programs would hav…
a68814f 
…e the note play with the wrong program [SM64: NCS_SE_PT_METAL_HIP_ATTACK (ID: 166)]
@nectarboy
Reworked notes to play immediately instead of sending a message. This…
7ff20b5 
… fixes numerous issues caused by the state of the sequence changing after the note command is sent, leading to the notes being played wrong.
@nectarboy
Tie Commands now release playing notes instead of immediately stoppin…
da7f455 
…g them [SM64: NCS_SE_PT_STEP_HIT (ID: 182)]

Source: pret decomp; SND_seq.c
@nectarboy
Fixed multisample note messing up portamento [SM64: NCS_SE_VO_RET_NOC…
b4d5a4d 
…AP_W (ID: 183), NCS_SE_VO_RET_NOCAP_L (ID: 119)]
@nectarboy nectarboy marked this pull request as ready for review December 31, 2024 02:17
@nectarboy nectarboy merged commit fbb4b17 into master Dec 31, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nectarboy