[fix] Correctly propagate pointer-events: auto to children when set to box-none
#2789
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 03c6a93:
|
hassankhan
changed the title
pointer-events to children when set to box-nonepointer-events: auto to children when set to box-none
hassankhan
force-pushed
the
@hassankhan/correctly-propagate-pointerevents
branch
from
605b413 to
5202ca7
Compare
hassankhan
added a commit
to hassankhan/react-navigation
that referenced
this pull request
Jul 19, 2025
By replacing usages of `pointerEvents` to use styles instead of props, we won't get an annoying warning in the logs.x The underlying issue in React Native Web which prevented children of a `pointer-events: box-none` element from receiving pointer events is resolved by necolas/react-native-web#2789
hassankhan
added a commit
to hassankhan/react-navigation
that referenced
this pull request
Jul 19, 2025
By replacing usages of `pointerEvents` to use styles instead of props, we won't get an annoying warning in the logs. The underlying issue in React Native Web which prevented children of a `pointer-events: box-none` element from receiving pointer events is resolved by necolas/react-native-web#2789 Fixes react-navigation#12441
hassankhan
added a commit
to hassankhan/react-navigation
that referenced
this pull request
Jul 19, 2025
By replacing usages of `pointerEvents` to use styles instead of props, we won't get an annoying warning in the logs. The underlying issue in React Native Web which prevented children of a `pointer-events: box-none` element from receiving pointer events is resolved by necolas/react-native-web#2789 Fixes react-navigation#12441
hassankhan
added a commit
to hassankhan/react-navigation
that referenced
this pull request
Jul 19, 2025
By replacing usages of `pointerEvents` to use styles instead of props, we won't get an annoying warning in the logs. The underlying issue in React Native Web which prevented children of a `pointer-events: box-none` element from receiving pointer events is resolved by necolas/react-native-web#2789 Fixes react-navigation#12441
… to `box-none` Corrects `pointer-events: box-none` behavior to match what's described at https://reactnative.dev/docs/view#pointerevents Fixes necolas#2606
hassankhan
force-pushed
the
@hassankhan/correctly-propagate-pointerevents
branch
from
5202ca7 to
03c6a93
Compare
hassankhan
commented
Jul 21, 2025
| @@ -176,6 +176,30 @@ describe('StyleSheet/compile', () => { | |||
| ] | |||
| `); | |||
| }); | |||
|
|
|||
There was a problem hiding this comment.
Happy to remove the test if the maintainer(s) think the snapshot test above suffices
hassankhan
added a commit
to hassankhan/react-navigation
that referenced
this pull request
Jul 29, 2025
By replacing usages of `pointerEvents` to use styles instead of props, we won't get an annoying warning in the logs. The underlying issue in React Native Web which prevented children of a `pointer-events: box-none` element from receiving pointer events is resolved by necolas/react-native-web#2789 Fixes react-navigation#12441
hassankhan
added a commit
to hassankhan/react-navigation
that referenced
this pull request
Jul 29, 2025
By replacing usages of `pointerEvents` to use styles instead of props, we won't get an annoying warning in the logs. The underlying issue in React Native Web which prevented children of a `pointer-events: box-none` element from receiving pointer events is resolved by necolas/react-native-web#2789 Fixes react-navigation#12441
satya164
pushed a commit
to react-navigation/react-navigation
that referenced
this pull request
Aug 2, 2025
BREAKING CHANGE: the minimum required version for `react-native-web` is now `~0.21.0` **Motivation** By replacing usages of `pointerEvents` to use styles instead of props, we won't get an annoying warning in the logs. The underlying issue in React Native Web which prevented children of a `pointer-events: box-none` element from receiving pointer events is resolved by necolas/react-native-web#2789. A follow-up fix to React Native Testing Library was also required, PR here callstack/react-native-testing-library#1799. Fixes #12441 **Test plan** CI (unit + E2E)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrects
pointer-events: box-nonebehavior to match what's described at https://reactnative.dev/docs/view#pointereventsFixes #2606