Skip to content

Conversation

wallyqs
Copy link
Member

@wallyqs wallyqs commented Oct 7, 2025

Follow up from a couple of the previous PRs:

  • Move nats-server package from import nats.server into import nats.testing.server instead

@wallyqs wallyqs marked this pull request as draft October 7, 2025 12:51
@wallyqs wallyqs force-pushed the uv-nats-testing-server branch from 6da65ae to 35ded54 Compare October 7, 2025 13:06
@wallyqs wallyqs marked this pull request as ready for review October 7, 2025 13:07
@Jarema
Copy link
Member

Jarema commented Oct 7, 2025

@wallyqs why we want to move it back to nats package?
It's a dev dependency for us, and very rarely for users.
In many clients we try to split those. And as javascript did recently - even split core nats from js, kv and object store.

Copy link
Collaborator

@caspervonb caspervonb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heya, so this seems to undo the addition of workspaces?

Keeping nats-server as its own package is beneficial for both us and the ecosystem, it's its own little standalone thing that exists without knowledge of anything but the existence of the nats-server binary being in path and some of its options.

Avoids cyclical dependencies for us as-well, easy to depend on siblings, hard to depend on a manifest package.

@wallyqs wallyqs force-pushed the uv-nats-testing-server branch from 840e3c5 to bbea82a Compare October 8, 2025 09:57
@wallyqs
Copy link
Member Author

wallyqs commented Oct 8, 2025

Updated to keep the workspace and instead only changed the import to nats.testing.server.
I think we need to add a matrix step on CI where we run tests with these deps: aiohttp, aiofiles, nkeys (websockets + nkeys tests)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants