feat(nats/client): make stats extensible #721
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace the stats dictionary by a class and interface, that is extensible to allow users to replace the stats collection by their own custom stats collector. Resolves nats-io#720 Signed-off-by: Tim Drijvers <[email protected]>
timdrijvers
force-pushed
the
client-stats-extensible
branch
from
73765ad to
9fa1324
Compare
NiekvanderLinden
approved these changes
Aug 14, 2025
|
Cautious about adding overhead to the I/o loop so not sure about this, as one could always just poll for deltas in an async coroutine? have you considered just calculating the diff every interval? As far as I know, all of the clients just provide these as "dumb" (often atomic) counters. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the stats dictionary by a class and interface, that is extensible to allow users to replace the stats collection by their own custom stats collector.
Resolves #720