Skip to content

Update 2-playground-tutorial.md #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 12, 2018

Conversation

cfjedimaster
Copy link
Contributor

Simply adds text to say what to set height and width too. Otherwise the user has to scroll down and find the completed source. For me, this was annoying because the previous instructions stood on their own.

Simply adds text to say _what_ to set height and width too. Otherwise the user has to scroll down and find the completed source. For me, this was annoying because the previous instructions stood on their own.
@nativescript-vue-bot
Copy link

Deploy preview for nativescript-vue ready!

Built with commit 9e7003d

https://deploy-preview-204--nativescript-vue.netlify.com

@rigor789 rigor789 merged commit a5a56f8 into nativescript-vue:master Oct 12, 2018
@cfjedimaster
Copy link
Contributor Author

It is a bit too late, but I wanted to add a comment. As I go through the guide more and more, it appears as if the intent is to NOT have direct instructions for everything. So this change may not have been necessary. I've kinda given up on following the instructions and instead read them for their intent (changing the behavior to X).

I'm probably overthinking this. Sorry!. ;)

@rigor789
Copy link
Member

@cfjedimaster well in this case I think it makes sense, to not leave the reader hanging. I'm a bit hesitant on merging changes into the playground tutorial though, as @ikoevska did most of the work, and I don't want to mess anything up. :)

@cfjedimaster
Copy link
Contributor Author

Given that the rest of the content doesn't seem to assume you can just read the step and know what to do, I'd say maybe kill this. For me, it was an obvious brick wall but it seems to be the norm for the rest of the guide. I kinda don't like that - but I kinda get how it cuts down on the noise a bit.

So I'm totally fine with this not going through and I apologize for any wasted time!

@ikoevska
Copy link
Contributor

Hello,

I appreciate the feedback and I'm OK with making this explicit.

As @cfjedimaster noted, the intention of the tutorial is to rather make you think how to do stuff and figure out some stuff on your own (otherwise, it would be only mechanical copy/paste or fill in the blanks which does not really teach you anything). I am completely open to a wider discussion whether we need to make the tutorial more explicit or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants