Skip to content

Update 2-playground-tutorial.md #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 15, 2018
Merged

Conversation

funzeye
Copy link
Contributor

@funzeye funzeye commented Sep 20, 2018

no reference to this id in code or steps. Included by mistake?

no reference to this id in code or steps. Included by mistake?
@nativescript-vue-bot
Copy link

Deploy preview for nativescript-vue ready!

Built with commit 77cf5e7

https://deploy-preview-191--nativescript-vue.netlify.com

@rigor789
Copy link
Member

rigor789 commented Oct 9, 2018

Hey @funzeye thanks for all the PRs, the reason I haven't merged them (yet) is that @ikoevska has written the playground tutorial, and the changes might need to be added to a couple more places.

@ikoevska when you get the chance, could you review the PRs, as I don't want to break your workflow!

Thanks :)

@ikoevska
Copy link
Contributor

ikoevska commented Oct 15, 2018

Definitely an error. Thanks for spotting that and fixing it. 👍 on my side.

@rigor789 rigor789 merged commit 4883d03 into nativescript-vue:master Oct 15, 2018
@rigor789
Copy link
Member

Thanks @ikoevska!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants