Skip to content

Conversation

miuirussia
Copy link

@miuirussia miuirussia commented Apr 26, 2023

Description of problem in #31

@natefaubion
Copy link
Owner

Can you clarify the intent of the implementations so we can discuss whether or not it makes sense overall? If I understand correctly, this is ultimately checking the hash as part of end. I would argue that this is not correct, semantically. Hash is similar to query parameters, which end does not check either, and I think that's the right thing to do. In my opinion, backtracking on a hash is dubious as a design constraint, but if one insists, I think it would be better to have a different combinator similar to to end for the hash specifically.

@miuirussia
Copy link
Author

miuirussia commented Apr 27, 2023

Can you clarify the intent of the implementations so we can discuss whether or not it makes sense overall?

It needs for correctly match path, as described in #31

If I understand correctly, this is ultimately checking the hash as part of end

Agreed, we probably need something like strictEnd that doesn't ignore the rest of the parsing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants