Fix #53, Opaque CFE_SB_MsgId_t values #54
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jphickey
added
the
CCB:Ready
jphickey
force-pushed
the
fix-53-opaque-msgid
branch
from
b9a5193 to
73c9083
Compare
Contributor
Author
|
Note - pushed a simpler version of the update. However this one requires that nasa/cFE#592 be pulled first or in the same cycle. The main changes are:
|
This was referenced Apr 8, 2020
Contributor
|
Related to nasa/cFE#592 |
Contributor
|
CCB 20200408 - Split up into parts. |
astrogeco
added
CCB - 20200408
and removed
CCB:Ready
astrogeco
suggested changes
Apr 8, 2020
Contributor
astrogeco
left a comment
astrogeco
left a comment
There was a problem hiding this comment.
Marking based on CCB 20200408
skliper
added
the
CCB:Ignore
Do not assume CFE_SB_MsgId_t is implicitly integral in nature. When an integer value is required for printing or backward compatibility, use the explicit conversion routine to get this.
jphickey
force-pushed
the
fix-53-opaque-msgid
branch
from
73c9083 to
e691304
Compare
skliper
approved these changes
May 5, 2020
skliper
approved these changes
May 5, 2020
astrogeco
added
CCB:Ready
Contributor
|
CCB 20200506 - APPROVED |
astrogeco
added
CCB-20200506
and removed
CCB:Ready
astrogeco
approved these changes
May 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Apply the
CFE_SB_MsgIdToValue()andCFE_SB_ValueToMsgId()routines where compatibility with an integer MsgId is necessary - syslog prints, events, compile-time MID#definevalues.Fixes #53
Testing performed
Unit test
Execute CFE and sanity-check normal operation - send commands to app using
cmdUtiland confirm commands are processed normally.Expected behavior changes
No impact to behavior.
System(s) tested on
Ubuntu 18.04 LTS, 64-bit
Additional context
In future versions of CFE SB the MsgId type might not be a simple integer, so this is one step in the direction of avoiding this assumption in apps.
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.