Filterable create #7978
Filterable create #7978
Conversation
…on annoatation tab
…urn annotatable types, cleaned up use of hasNumericTelemetry elsewhere in the code
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7978 +/- ##
==========================================
+ Coverage 57.76% 58.72% +0.95%
==========================================
Files 684 442 -242
Lines 27560 13751 -13809
Branches 2701 0 -2701
==========================================
- Hits 15920 8075 -7845
+ Misses 11306 5676 -5630
+ Partials 334 0 -334
... and 416 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
- Create menu labels can now wrap. - Line height, padding adjusted for menu items. - Create menu filter input slimmed down a bit.
There was a problem hiding this comment.
Commenting mostly on UI-related aspects:
- Filtering in the Create menu is operating on both the object name and the description. For example, enter filter by "row" and note that you'll see 4 objects, none of which have that string in their names. This should not use the description field and only filter by name.
- Now that we've done Enter and Esc keys in dialogs, the Time Conductor popup also expects the love. Currently, the Enter key only works if the user's cursor is within a numeric input, and Esc doesn't do anything. Can we make this consistent with the dialogs?
|
Looks really good, and love the quality of life improvements. Pushed a few small tweaks:
|
|
@jvigliotta Needs tests, thanks. |
| this.$emit('on-save'); | ||
| }, | ||
| handleKeyDown({ key }) { | ||
| if (key === 'Enter' && !this.isInvalid) { |
| }, | ||
| methods: { | ||
| handleKeyDown({ key }) { | ||
| if (key === 'Enter' && !this.hasInputValidityError) { |
There was a problem hiding this comment.
There seems to be no way to target the [X] button in the Time popup to hit Enter and cancel the action.
The check button action works fine on Enter.
There was a problem hiding this comment.
Yeah it's not setup in that way, it will cancel if you press the 'Escape' key and submit if you hit the 'Enter' key
…to confirm you can submit time conductor changes with enter key
Closes #7977
Describe your changes:
Added some nice to have functionality, such as:
All Submissions:
Author Checklist
type:label? Note: this is not necessarily the same as the original issue.Reviewer Checklist