Skip to content

Update headless-gui action in build (fix screenshots) #294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Dec 15, 2023
Merged

Update headless-gui action in build (fix screenshots) #294

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
2c1aefb
Don't run window manager in headless-gui action during build
aganders3 Dec 5, 2023
a875960
Make headless-gui configs non-empty (but empty)
aganders3 Dec 5, 2023
cc57d39
Update deploy_docs.yml as well
aganders3 Dec 5, 2023
5bdd8e1
Try a different way to skip
aganders3 Dec 5, 2023
d02427b
Try PySide for some reason
aganders3 Dec 6, 2023
e2175d7
Use headless-gui dev branch
aganders3 Dec 6, 2023
adb45bc
Use xvfb-screen-size
aganders3 Dec 6, 2023
0f32623
Update to use released headless-gui@v2 with new default screen size
aganders3 Dec 6, 2023
54fcbdd
Use `pyqt` (via `all`) instead of `pyside` when installing napari
aganders3 Dec 6, 2023
3d1f64d
Don't change .circleci/config.yml
psobolewskiPhD Dec 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions .github/workflows/build_docs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,14 +53,18 @@ jobs:
python -c 'import napari.layers; print(napari.layers.__doc__)'

- name: Build Docs
uses: aganders3/headless-gui@v1
uses: aganders3/headless-gui@v2
env:
GOOGLE_CALENDAR_ID: ${{ secrets.GOOGLE_CALENDAR_ID }}
GOOGLE_CALENDAR_API_KEY: ${{ secrets.GOOGLE_CALENDAR_API_KEY }}
PIP_CONSTRAINT: ${{ github.workspace }}/napari/resources/constraints/constraints_py3.10_docs.txt
with:
run: make -C docs docs

# skipping setup stops the action from running the default (tiling) window manager
# the window manager is not necessary for docs builds at this time and it was causing
# problems with screenshots (https://github.com/napari/docs/issues/285)
linux-setup: "echo 'skip setup'"
linux-teardown: "echo 'skip teardown'"

- name: Upload artifact
uses: actions/upload-artifact@v3
Expand Down
7 changes: 6 additions & 1 deletion .github/workflows/deploy_docs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ jobs:
python -c 'import napari.layers; print(napari.layers.__doc__)'

- name: Build Docs
uses: aganders3/headless-gui@v1
uses: aganders3/headless-gui@v2
env:
GOOGLE_CALENDAR_ID: ${{ secrets.GOOGLE_CALENDAR_ID }}
GOOGLE_CALENDAR_API_KEY: ${{ secrets.GOOGLE_CALENDAR_API_KEY }}
Expand All @@ -63,6 +63,11 @@ jobs:
# the napari-docs repo is cloned into a docs/ folder, hence the
# invocation below. Locally, you should simply run make docs
run: make -C docs docs GALLERY_PATH=../examples/
# skipping setup stops the action from running the default (tiling) window manager
# the window manager is not necessary for docs builds at this time and it was causing
# problems with screenshots (https://github.com/napari/docs/issues/285)
linux-setup: "echo 'skip setup'"
linux-teardown: "echo 'skip teardown'"

- name: Deploy Docs
uses: peaceiris/actions-gh-pages@v3
Expand Down