Catch invalid slice expressions at compile time #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkantor
force-pushed
the
invalid-slices-are-compile-error
branch
from
7f4fd53 to
d06d5b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For programs which compile expressions and then later evaluate them it is nice to flag invalid syntax during the compilation stage.
As far as I can tell, invalid slices with a
stepof0were the only realistic situation where this wasn't already the case (it's validated byTreeInterpreter.tsbut ignored in the compiler). This pull request changes that to make invalid slice expressions likea[2:1:0]trigger compilation errors.