Skip to content

Conversation

@josesimoes
Copy link
Member

Description

  • Add converter to properly convert arguments to wstring.

Motivation and Context

  • A bug was introduced on the work with WIN targets that was preventing succesful parsing of the arguments.

How Has This Been Tested?

  • Local run of unit tests from a failing pipeline build.

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue with code or algorithm)
  • New feature (non-breaking change which adds functionality to code)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dev Containers (changes related with Dev Containers, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist

  • My code follows the code style of this project (only if there are changes in source code).
  • My changes require an update to the documentation (there are changes that require the docs website to be updated).
  • I have updated the documentation accordingly (the changes require an update on the docs in this repo).
  • I have read the CONTRIBUTING document.
  • I have tested everything locally and all new and existing tests passed (only if there are changes in source code).

- Add converter to properly convert arguments to wstring.
@josesimoes josesimoes added the Platform: Virtual Device & WIN32 Everything related specifically with WIN32 and .NET tool builds label Dec 13, 2022
@josesimoes josesimoes merged commit e66624a into nanoframework:main Dec 13, 2022
@josesimoes josesimoes deleted the fix-parsing-args-win32 branch December 13, 2022 03:37
aromaa pushed a commit to aromaa/nf-interpreter that referenced this pull request Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Platform: Virtual Device & WIN32 Everything related specifically with WIN32 and .NET tool builds Type: bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants