-
Notifications
You must be signed in to change notification settings - Fork 39.1k
fix(Customer.io Node): Allow EU customer.io domains in credential #14880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Customer.io Node): Allow EU customer.io domains in credential #14880
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mrge found 1 issue across 1 file. View it in mrge.io
if (url.hostname === 'track.customer.io' || url.hostname === 'api.customer.io') { | ||
if ( | ||
url.hostname === 'track.customer.io' || | ||
url.hostname === 'track-eu.customer.io' || |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Authentication logic doesn't properly leverage the 'region' credential property
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
…community-issue-customerio-node-fails-on-requests-to-eu
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
✅ All Cypress E2E specs passed |
Got released with |
…n-io#14880) Co-authored-by: Michael Kret <[email protected]>
Summary
Allow EU customer.io domains in credential
Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/NODE-2659/community-issue-customerio-node-fails-on-requests-to-eu-servers
Review / Merge checklist
release/backport
(if the PR is an urgent fix that needs to be backported)