Skip to content

fix(Customer.io Node): Allow EU customer.io domains in credential #14880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

elsmr
Copy link
Member

@elsmr elsmr commented Apr 24, 2025

Summary

Allow EU customer.io domains in credential

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/NODE-2659/community-issue-customerio-node-fails-on-requests-to-eu-servers

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mrge found 1 issue across 1 file. View it in mrge.io

if (url.hostname === 'track.customer.io' || url.hostname === 'api.customer.io') {
if (
url.hostname === 'track.customer.io' ||
url.hostname === 'track-eu.customer.io' ||
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Authentication logic doesn't properly leverage the 'region' credential property

Copy link

codecov bot commented Apr 24, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...odes-base/credentials/CustomerIoApi.credentials.ts 0.00% 2 Missing ⚠️

📢 Thoughts on this report? Let us know!

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team node/improvement New feature or request labels Apr 24, 2025
…community-issue-customerio-node-fails-on-requests-to-eu
Copy link
Contributor

@michael-radency michael-radency left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

✅ All Cypress E2E specs passed

@michael-radency michael-radency merged commit 0c7f7b3 into master Apr 28, 2025
34 checks passed
@michael-radency michael-radency deleted the node-2659-community-issue-customerio-node-fails-on-requests-to-eu branch April 28, 2025 08:19
@github-actions github-actions bot mentioned this pull request Apr 28, 2025
@janober
Copy link
Member

janober commented Apr 28, 2025

Got released with [email protected]

ozcangungor pushed a commit to ozcangungor/n8n that referenced this pull request May 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team node/improvement New feature or request Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants