fix(editor): Data in input/output panel incorrectly mapped #14878
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
autologie
changed the base branch from
master
to
sug-36-logs-tree-perf-improvement
Codecov ReportAttention: Patch coverage is 📢 Thoughts on this report? Let us know! |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
packages/frontend/@n8n/design-system/src/components/N8nRadioButtons/RadioButton.vue
Show resolved
Hide resolved
packages/frontend/editor-ui/src/components/CanvasChat/future/components/LogsOverviewPanel.vue
Show resolved
Hide resolved
packages/frontend/@n8n/design-system/src/components/N8nRadioButtons/RadioButtons.vue
Show resolved
Hide resolved
packages/frontend/@n8n/design-system/src/components/N8nRadioButtons/RadioButtons.vue
Show resolved
Hide resolved
mutdmour
previously approved these changes
Apr 25, 2025
| describe('Logs', () => { | ||
| // TODO: the test can be written without AI nodes once https://linear.app/n8n/issue/SUG-39 is implemented | ||
| it('should open NDV with the run index that corresponds to clicked log entry'); | ||
| it('should show input and output data of correct run index and branch', () => { |
There was a problem hiding this comment.
looking forward to seeing more tests here. Created a ticket like we discussed before https://linear.app/n8n/issue/SUG-47/tech-debt-write-tests-for-new-logs-view
|
|
mutdmour
previously approved these changes
Apr 28, 2025
|
|
mutdmour
approved these changes
Apr 28, 2025
|
✅ All Cypress E2E specs passed |
|
Got released with |
ozcangungor
pushed a commit
to ozcangungor/n8n
that referenced
this pull request
May 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the bug in showing input data in the new logs view, specifically the bug when the input of a node's run comes from one of branches of the previous node (e.g., true/false branch of "If" node). The fix is implemented by utilizing
sourcefield where the previous node name, output branch and run index is stored.Also styling tweaks for radio button and tab component is added based on the latest feedback from the designer.
To run locally, set
N8N_LOGS_2025_SPRINGtotruein local storage and refresh the browser.Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/SUG-46/bug-data-in-inputoutput-panel-incorrectly-mapped
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)