-
-
Notifications
You must be signed in to change notification settings - Fork 78
Add support for Slack-flavored markdown #398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for the PR, will review tomorrow during my day. I have kick started the CI. |
|
@Klikini Hey, sorry about the electronic silence, had to travel a bit due to personal work. I will review this PR this week and pull it in. |
|
@Klikini The code changes look fine, I will pull it in and make few changes. Is it possible for you to add some unit tests for this functionality? |
|
Sure, I should have some time later this week to work on tests. |
|
Unit tests are done. I only ran them locally under .NET 8, but hopefully they work the same under .NET 6 and 7. |
|
Thank you, will take a look at it in my morning and pull it in. |
|
Is this going to be part of an official release @mysticmind |
|
Sorry, have been out with a personal emergency. I will take look and release in the next few days. |
|
Thank you! I hope everything is okay. |
Hey @Klikini, thanks for the concern, getting better! |
I added a new
SlackFlavoredconfig option:When enabled, ReverseMarkdown will:
*instead of**for bold_instead of*for italic~instead of~~forstrikethrough•) for lists because Slack does not parse lists using*or-when sending messages via the APISlackUnsupportedTagExceptionwhen trying to convert the following tags because Slack doesn't support them in messages:<hr><img><sup><table>, including<td>and<tr>