Skip to content

Conversation

jeremykendall
Copy link
Contributor

Addresses suggestions from conversation in #4.

  • Adds final to equals()
  • Update tests per suggestions from @mirfilip
    • Rewrite original tests
    • Add tests proving equals() handles problematic values properly
  • Add equals() to documentation

@mirfilip
Copy link

mirfilip commented Oct 6, 2016

That's a solid PR 👍

@chippyash
Copy link

Good practice. Good pr.

@mnapoli
Copy link
Member

mnapoli commented Oct 9, 2016

Awesome!

@mnapoli mnapoli merged commit 9818c63 into myclabs:master Oct 9, 2016
@jeremykendall
Copy link
Contributor Author

Thanks everyone!

@jeremykendall jeremykendall deleted the feature/declare-equals-final branch October 9, 2016 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants