-
-
Notifications
You must be signed in to change notification settings - Fork 132
Correct json serialization of Enum object instead of just {} #30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -22,7 +22,7 @@ | |
} | ||
}, | ||
"require": { | ||
"php": ">=5.3" | ||
"php": ">=5.4" | ||
}, | ||
"require-dev": { | ||
"phpunit/phpunit": "4.*", | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -15,7 +15,7 @@ | |
* @author Daniel Costa <[email protected]> | ||
* @author Mirosław Filip <[email protected]> | ||
*/ | ||
abstract class Enum | ||
abstract class Enum implements \JsonSerializable | ||
{ | ||
/** | ||
* Enum value | ||
|
@@ -73,6 +73,19 @@ public function __toString() | |
return (string)$this->value; | ||
} | ||
|
||
/** | ||
* (PHP 5 >= 5.4.0)<br/> | ||
* Specify data which should be serialized to JSON | ||
* @link http://php.net/manual/en/jsonserializable.jsonserialize.php | ||
* @return mixed data which can be serialized by <b>json_encode</b>, | ||
* which is a value of any type other than a resource. | ||
*/ | ||
public function jsonSerialize() | ||
{ | ||
return $this->getValue(); | ||
} | ||
|
||
|
||
/** | ||
* Returns the names (keys) of all constants in the Enum class | ||
* | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a BC break, the PR cannot be merged as is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand that as you can see in comment. You may consider to use that changeset in new major version or some other branch.
I just wanted to let you know that json problem exists and there is simple solution
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand, thank you for providing the patch.
There is no new BC-breaking version planned since this is just a minor thing and a PHP implementation is in the works for 7.1, so I'll be closing this. Users can still implement this in sub-classes, but I don't see a big value since it doesn't support deserialization.