Correct json serialization of Enum object instead of just {} #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -22,7 +22,7 @@ | |||
| } | |||
| }, | |||
| "require": { | |||
| "php": ">=5.3" | |||
| "php": ">=5.4" | |||
There was a problem hiding this comment.
This is a BC break, the PR cannot be merged as is.
There was a problem hiding this comment.
I understand that as you can see in comment. You may consider to use that changeset in new major version or some other branch.
I just wanted to let you know that json problem exists and there is simple solution
There was a problem hiding this comment.
I understand, thank you for providing the patch.
There is no new BC-breaking version planned since this is just a minor thing and a PHP implementation is in the works for 7.1, so I'll be closing this. Users can still implement this in sub-classes, but I don't see a big value since it doesn't support deserialization.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JsonSerializable was added only in PHP 5.4, but that's highly useful change