Support multi-row insert on SQL builder class

[sivdead]

make AbstratSQL.INSERT_VALUES could be invoke multiple times to do batch insert.

[harawata]

Thank you for the PR, @sivdead !

It could break backward compatibility, though.
Please see the following test case. It will fail if this PR is merged.

  @Test
  public void variableLengthArgumentOnIntoColumnsAndValues() {
    final String sql = new SQL() {{
      INSERT_INTO("TABLE_A").INTO_COLUMNS("a", "b").INTO_VALUES("#{a}").INTO_VALUES("#{b}");
    }}.toString();
    assertEquals("INSERT INTO TABLE_A\n (a, b)\nVALUES (#{a}, #{b})", sql);
  }

I'm not sure what's the best approach here, but it might be better to add a new method instead of modifying INTO_VALUES.

Cc-ing @h3adache @kazuki43zoo

[kazuki43zoo]

it might be better to add a new method instead of modifying INTO_VALUES.

I agree with it.

For example, one approach is as follow:

  @Test
  public void multipleRowsInsert() {
    final String sql = new SQL() {{
      INSERT_INTO("TABLE_A")
          .INTO_COLUMNS("a", "b")
          .INTO_VALUES("#{a1}", "#{b1}")
          .ADD_ROW()
          .INTO_VALUES("#{a2}", "#{b2}")
      ;
    }}.toString();

    assertEquals("INSERT INTO TABLE_A\n (a, b)\nVALUES \n (#{a1}, #{b1}),\n (#{a2}, #{b2})", sql);
  }

NOTE: Multiple rows insert style is different by database vender and versions.

[sivdead]

it might be better to add a new method instead of modifying INTO_VALUES.

I agree with it.

For example, one approach is as follow:

  @Test
  public void multipleRowsInsert() {
    final String sql = new SQL() {{
      INSERT_INTO("TABLE_A")
          .INTO_COLUMNS("a", "b")
          .INTO_VALUES("#{a1}", "#{b1}")
          .ADD_ROW()
          .INTO_VALUES("#{a2}", "#{b2}")
      ;
    }}.toString();

    assertEquals("INSERT INTO TABLE_A\n (a, b)\nVALUES \n (#{a1}, #{b1}),\n (#{a2}, #{b2})", sql);
  }

NOTE: Multiple rows insert style is different by database vender and versions.

thanks for the advice,so I add a method ADD_ROW to avoid that multi INTO_VALUES in single insert problem.
For example:

  @Test
  public void batchInsertWithMultipleInsertValues(){
    final String sql = new SQL() {{
      INSERT_INTO("TABLE_A");
      INTO_COLUMNS("a", "b");
      INTO_VALUES("#{a1}");
      INTO_VALUES("#{b1}");
      ADD_ROW();
      INTO_VALUES("#{a2}");
      INTO_VALUES("#{b2}");
    }}.toString();
    System.out.println(sql);
    assertEquals("INSERT INTO TABLE_A\n (a, b)\nVALUES \n (#{a1}, #{b1}),\n (#{a2}, #{b2})", sql);
  }

I see that batch insert in oracle is different than others,but I don't know how to get database type or version in sqlBuilder-,-

[harawata]

Thank you for the update, @sivdead !

@kazuki43zoo ,
Does ADD_ROW() look OK to you?
According to Wikipedia, this syntax is the standard one, so I personally think it's OK even if it does not work with all DBs.

I may request a few minor code changes later.

[kazuki43zoo]

Hi @harawata , sorry for late reply.

Does ADD_ROW() look OK to you?

I think it is OK.

According to Wikipedia, this syntax is the standard one, so I personally think it's OK even if it does not work with all DBs.

I thinks so, too!

[harawata]

Hi @sivdead ,
I'm sorry about the delay! There were some high priority issues.
I have added a few comments.
Please take a look when you have time.

@kazuki43zoo ,
Thanks! Feel free to add comments if you noticed anything.

[sivdead]

Hi @sivdead ,
I'm sorry about the delay! There were some high priority issues.
I have added a few comments.
Please take a look when you have time.

@kazuki43zoo ,
Thanks! Feel free to add comments if you noticed anything.

Hi @sivdead ,
I'm sorry about the delay! There were some high priority issues.
I have added a few comments.
Please take a look when you have time.

@kazuki43zoo ,
Thanks! Feel free to add comments if you noticed anything.

thanks for correcting my mistake! and also sorry about the delay reply :(

[harawata]

Thank you for the update, @sivdead !
I have resolved the conflict and made a few minor adjustment.

@kazuki43zoo ,
Could you do the final check and merge if everything is OK?
Thanks in advance!

[kazuki43zoo]

@sivdead

I've added some small comments. If you have a time, please check it.

[sivdead]

@sivdead

I've added some small comments. If you have a time, please check it.

i have do as you suggested,again thank you for helping me a lot on this pr :)

[kazuki43zoo]

@sivdead Thanks for your rework! But I have some change requests. Please check new comment and replying comments.

[sivdead]

@sivdead Thanks for your rework! But I have some change requests. Please check new comment and replying comments.

get it fixed