Skip to content

Conversation

Eism
Copy link
Contributor

@Eism Eism commented Oct 20, 2025

see #29888

@DmitryArefiev
Copy link
Contributor

Tested LinuxUbuntu24.04.3 LTS. It has a regression with range selection when editing text (unable to select):

Screencast.from.2025-10-21.11-35-20.webm

cbjeukendrup
cbjeukendrup previously approved these changes Oct 21, 2025
@cbjeukendrup cbjeukendrup dismissed their stale review October 21, 2025 13:42

Hadn't seen comment about regression yet

QString sessionType = qEnvironmentVariable("XDG_SESSION_TYPE");
QString platformName = qGuiApp->platformName();

return sessionType.contains(WAYLAND) || platformName.contains(WAYLAND);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe all variables here can be made static, including the final result
or like this

static int is_wayland = -1;
if (is_wayland == -1) {
    QString sessionType = qEnvironmentVariable("XDG_SESSION_TYPE");
    QString platformName = qGuiApp->platformName();
    is_wayland =  sessionType.contains("wayland") || platformName.contains("wayland");
}
return is_wayland;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants