Make "Disable version checking" visible as an Advanced preference #30472
+2
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rather than hiding it completly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rather than hiding it completly (in DevTools and for development builds only) and keeping it a secret setting known to only a handfull people.
(that setting exists in 4.2.1 and 4.3.x (via #20907) and 4.4.0 and later (via #20906))
Actually this does not really disable the version checking (which still happens and gets warned about) but rather the denial to load a newer score file version.
Maybe we should rename it accordingly.
Maybe it should even default to
truefor developement builds.Whether opening the score works or does not work or even crashes is an entirely different issue, but being an Advanced setting should make it hidden enough ;-)
Resolves: #20899