-
-
Notifications
You must be signed in to change notification settings - Fork 474
Allow multiple ignored elements to be passed to processLineOfSight #2032
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
we shouldn't allow bool to be passed as ignoredElement1
Wouldn't it be better to take a table of elements? elements = {}
processLineOfSight(...,unpack(elements),...) -- can't do this I suppose you could the put last arguments as the last values in the table. |
I'll add the ability to pass a table, as well as vararg. Having it at the end would be weird, because we have to keep the original argument order to some extent. |
We should remove all of these types of comment, they're stupid.
Other than these comments you're fine imho. |
Time to merge this. |
Vararg removed. Test resource: los.zip Spawns 50 bin objects in a row. Use command e.g This resource also tests backwards compatibility by passing |
Is there anything left to do here or why is it not merged? |
Nothing left to do here, not merged yet because feature freeze is on (https://discord.com/channels/801330706252038164/801330706252038167/1059094962853130250). Will be merged for 1.6. |
This allows multiple ignore elements to be passed to processLineOfSight, via table of elements.
It is backwards compatible. If you pass a single element, or nil as
ignoredElements
it has the same behaviour as before.Partially resolves #1549
I will submit a separate PR for isLineOfSightClear